fix: inline style css sourcemap #7434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
sapphi-red
commented
Mar 24, 2022
Comment on lines
+41
to
+43
| return decodeURIComponent( | ||
| normalizePath(path.join(server.config.root, url.slice(1))) | ||
| ) |
There was a problem hiding this comment.
filename of transformIndexHtml hook was not normalized. This PR also fixes that. (it was required to fix the issue)
patak-dev
approved these changes
Mar 24, 2022
|
Thanks for the quick fix @sapphi-red! Let's release a new patch so we can continue to test this in the wild. |
|
@patak-dev This PR still does not fix storybook-builder-vite completely. I will describe it why in storybookjs/builder-vite#288. |
|
@sapphi-red ok, let's wait then for releasing the patch. No rush 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#7432
fixes
Sourcemap for "something.html" points to missing source files.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).