Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-react): turn off jsx for .ts #5198

Merged
merged 1 commit into from
Oct 5, 2021
Merged

fix(plugin-react): turn off jsx for .ts #5198

merged 1 commit into from
Oct 5, 2021

Conversation

hyrious
Copy link
Contributor

@hyrious hyrious commented Oct 4, 2021

Description

interface A {
  optional?: string;
}

const a = {};
const b = <A>a;

export { b };

This ts code will fail when using plugin-react, because <A> is treated as a jsx(tsx) tag.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

fix #5102

@Shinigami92 Shinigami92 requested a review from aleclarson October 5, 2021 04:15
@aleclarson aleclarson changed the title fix(plugin-react): turn off jsx for .ts (fix #5102) fix(plugin-react): turn off jsx for .ts Oct 5, 2021
@aleclarson aleclarson merged commit 916f9d3 into vitejs:main Oct 5, 2021
@svicalifornia
Copy link

Thanks!

@hyrious hyrious deleted the patch-1 branch October 5, 2021 23:11
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Oct 11, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite react plugin interprets <Type>(…) typecast prefixes in .ts files as TSX tags
4 participants