fix(runtime): fix sourcemap with prepareStackTrace
#16220
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
prepareStackTrace
since 5.1.5 #16178As explained in #16178 (comment), "replace bias" transform which is used for
runtime.js
build was causing a bug.In this PR, I removed this transform since it doesn't seem particularly worth squeezing out these three lines of code on Vite side. I think it's always possible for end-users to minify the final build further if they wish to do so.
diff view of "false" vs "no transform"
I don't know but if this known constant folding has some perf impact, then maybe it's okay to put to
false
. Let me know if anyone knows about the perf aspect of things.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).