-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: move basic ssl setup to external plugin, fix #8532 #8961
Conversation
✅ Deploy Preview for vite-docs-main ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should document this in the migration guide too. Also I found https://github.com/liuweiGL/vite-plugin-mkcert which looks similar to @vitejs/plugin-basic-ssl
👀
README.md
Outdated
| [@vitejs/plugin-vue-jsx](packages/plugin-vue-jsx) | [](packages/plugin-vue-jsx/CHANGELOG.md) | | ||
| [@vitejs/plugin-react](packages/plugin-react) | [](packages/plugin-react/CHANGELOG.md) | | ||
| [@vitejs/plugin-legacy](packages/plugin-legacy) | [](packages/plugin-legacy/CHANGELOG.md) | | ||
| [@vitejs/plugin-basic-ssl](https://github.com/vitejs/vite-plugin-basic-ssl) | [](https://github.com/vitejs/vite-plugin-basic-ssl/CHANGELOG.md) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be confusing to show this here given it's not part of the monorepo, and something we discourage as we want users to make a real cert 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is true. I'll remove it from here, and only keep it in the migration guide.
About vite-plugin-mkcert that looks a lot better. I don't know enough about the project to recommend it here. But I think someone should at some point do a PR to update the docs with recommendations.
Description
See for context:
What is the purpose of this pull request?