refactor!: move side effect of restart server to the caller

[CHOYSEN]

Description

make restart function more pure after expose it as a javascript API

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[netlify]

✅ Deploy Preview for vite-docs-main ready!

Name	Link
🔨 Latest commit	d63cdb3
🔍 Latest deploy log	https://app.netlify.com/sites/vite-docs-main/deploys/62b494e7572cff0008f2a499
😎 Deploy Preview	https://deploy-preview-8746--vite-docs-main.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[patak-dev]

Would you explain why we would like to avoid the printing of the new URLs when calling restart(), but still have them in the HMR logic?

[CHOYSEN]

User may use Javascript API, createServer doesn't print the url automatically, so i think it shouldn't print when restarting either.

import { createServer } from "vite";
import { SHOULD_PRINT_URL } from "./consts";

const server = await createServer({ base: "/a/", configFile: false });
SHOULD_PRINT_URL && server.printUrls();

async function restartServer() {
  await server.restart();
  SHOULD_PRINT_URL && server.printUrls();
}

// ...
server.config.inlineConfig.base = "/b/";
restartServer();

[CHOYSEN]

The printing code was added without considering that the restart function would be exposed, but for now I think that code should be left to the caller.These prints are still necessary for Vite CLI-powered applications, so i left them in HMR logic. :)

[sapphi-red]

This makes sense to me partially.

But when metaframeworks that uses createServer and uses their own function similar to server.printUrls, they still cannot change the output when the config is changed.

We might need to think about #6997 (comment) and #8986 together with this PR.

[patak-dev]

@CHOYSEN would you rebase this PR? Let's try to merge it for Vite 5, or otherwise decide if we prefer to keep things as is.

[CHOYSEN]

sure

[sapphi-red]

/ecosystem-ci run

[vite-ecosystem-ci]

📝 Ran ecosystem CI on 00528b4: Open

suite	result	latest scheduled
analogjs	✅ success	✅ success
astro	✅ success	✅ success
histoire	✅ success	✅ success
ladle	✅ success	✅ success
laravel	❌ failure	❌ failure
marko	❌ failure	❌ failure
nuxt	✅ success	✅ success
nx	❌ failure	❌ failure
previewjs	✅ success	✅ success
qwik	✅ success	✅ success
rakkas	✅ success	✅ success
sveltekit	✅ success	❌ failure
unocss	✅ success	✅ success
vike	✅ success	❌ failure
vite-plugin-pwa	❌ failure	❌ failure
vite-plugin-react	✅ success	✅ success
vite-plugin-react-pages	✅ success	✅ success
vite-plugin-react-swc	✅ success	✅ success
vite-plugin-svelte	✅ success	✅ success
vite-plugin-vue	✅ success	✅ success
vite-setup-catalogue	✅ success	✅ success
vitepress	✅ success	✅ success
vitest	✅ success	❌ failure

[bluwy]

The more I think about it, the more I'm unsure this is the right fix. This PR moves the printUrls away, but that still can be called in HMR. Personally I think the best way is this: "if printUrls was never called, then we also don't print it whenever we restart the server" 🤔

[bluwy]

Added the printing for shortcuts, but I'm still not sure if this is the right solution.

[patak-dev]

I think your latest changes looks good @bluwy, let's go with this approach

[patak-dev]

Oh, there is a conflict, I think you can merge it once it is resolved then.