Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

since Vite 3.0.0-alpha.5 with 2.0.0 -alpha.1 legacy plugin is producing code incompatible with ie 11 #8651

Closed
7 tasks done
kalvenschraut opened this issue Jun 18, 2022 · 1 comment · Fixed by #8660
Closed
7 tasks done
Labels
p4-important Violate documented behavior or significantly improves performance (priority) plugin: legacy

Comments

@kalvenschraut
Copy link

Describe the bug

In polyfills-legacy arrow functions are being used which are not valid syntax for IE 11.

Reproduction

https://github.com/RtVision/vite-alpha-legacy-repro

System Info

System:
    OS: Linux 5.15 Gentoo/Linux
    CPU: (4) x64 Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz
    Memory: 19.03 GB / 26.78 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 16.13.1 - /usr/bin/node
    Yarn: 1.22.18 - ~/.local/share/pnpm/yarn
    npm: 8.6.0 - /usr/bin/npm
    Watchman: 2022.03.21.00 - /usr/bin/watchman
  Browsers:
    Firefox: 91.7.0esr
  npmPackages:
    @vitejs/plugin-legacy: ^2.0.0-alpha.1 => 2.0.0-alpha.1
    vite: ^3.0.0-alpha.12 => 3.0.0-alpha.12

Used Package Manager

pnpm

Logs

No response

Validations

@kalvenschraut kalvenschraut changed the title since Vite 3.0.0-alpha.5 with 2.0.0 -alpha.1 legacy plugin is producing code not compatible with ie 11 since Vite 3.0.0-alpha.5 with 2.0.0 -alpha.1 legacy plugin is producing code incompatible with ie 11 Jun 18, 2022
@sapphi-red
Copy link
Member

It happens with plugin-legacy 1.8.2 and vite 3.0.0-alpha.5.
But it does not happen with plugin-legacy 1.8.2 and vite 3.0.0-alpha.4.

@sapphi-red sapphi-red added plugin: legacy p4-important Violate documented behavior or significantly improves performance (priority) and removed pending triage labels Jun 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p4-important Violate documented behavior or significantly improves performance (priority) plugin: legacy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants