-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(create-vite): align template styles with docs #8478
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool ✨
Looks mostly good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe a create-svelte isn't a bad idea for example if it doesn't exist already
Just to share, we have a create-svelte
which allows you to run npm init svelte
in order to create a new SvelteKit project
@benmccann nice! Looks like it creates a SvelteKit app, we already have a link to the SvelteKit docs in the templates with a call to action to check them out. I think that is good for Svelte here then. |
Co-authored-by: 翠 / green <[email protected]>
Co-authored-by: 翠 / green <[email protected]>
Co-authored-by: 翠 / green <[email protected]>
Co-authored-by: 翠 / green <[email protected]>
Co-authored-by: 翠 / green <[email protected]>
Co-authored-by: 翠 / green <[email protected]>
Co-authored-by: 翠 / green <[email protected]>
Co-authored-by: 翠 / green <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion but apart from that it LGTM 🚀
packages/create-vite/template-vue-ts/src/components/HelloWorld.vue
Outdated
Show resolved
Hide resolved
packages/create-vite/template-vue/src/components/HelloWorld.vue
Outdated
Show resolved
Hide resolved
packages/create-vite/template-vue/src/components/HelloWorld.vue
Outdated
Show resolved
Hide resolved
packages/create-vite/template-vue-ts/src/components/HelloWorld.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: Tony Trinh <[email protected]>
Co-authored-by: Tony Trinh <[email protected]>
Co-authored-by: Tony Trinh <[email protected]>
Co-authored-by: Tony Trinh <[email protected]>
Description
Fix #8385
Hopefully, this will help to make it more clear to users that these templates are a way to try out Vite with their favorite framework, but these aren't production-grade scaffolding tools that include the recommended setup for testing, linting, etc from each framework. Like Vue has done with create-vue, we should push other frameworks to off a similar tool (most of them are already working in complete frameworks like SvelteKit, maybe a create-svelte isn't a bad idea for example if it doesn't exist already).
The new docs-aligned theme should also make the experience better when reading the docs and jumping to the online StackBlitz playgrounds.
Changes include:
What is the purpose of this pull request?