fix(plugin-react): account for querystring in transform hook #5333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@vite/plugin-react
currently checks file extension in Rollup'stransform
hook. However, theid
parameter can contain querystrings when importing a component like this:This makes the plugin fail when testing
id.endsWith('x')
and similar checks.Additional context
Querystrings can be injected by other Vite plugins in order to apply conditional behavior.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).