fix(plugin-legacy): wrap chunks in IIFE #3783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we would need to keep the map from babel, and that's why the original PR get blocked since MagicString does not take source map input, while I am not familiar with babel transforming to support sourcemap |
|
@antfu thanks for the quick review! I've changed implementation to use babel plugin for transformations, so source map behavior should not change |
patak-dev
approved these changes
Jun 13, 2021
9 tasks
|
@antfu @patak-js sorry if I'm being annoying, but is there any release plan for that fix? |
|
We'll do a release on Monday or Tuesday including this fix |
|
@umidbekk |
javastation
pushed a commit
to javastation/vite
that referenced
this pull request
Jun 22, 2021
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solving the same problem as #2972, but contains tests and source map support (sorry for the duplicate, but original PR is not changed since the April and this bug block migration of the large codebase from the CRA to Vite).
If someone comes from google, it solves global scope pollution issues like:
Can't create duplicate variable: '_excludes',redeclaration of const _excludesorIdentifier '_excludes' has already been declarederrors caused by@babel/plugin-desctructuring(example)Issues with
styled-componentsoremotioncaused by@babel/plugin-transform-template-literals(example)What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).