fix(plugin-legacy): respect custom filenames formats, fix #2356

[anncwb]

fix #2356

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

---

Description

Additional context

[patak-dev]

@anncwb this looks good, thanks!

Would it be possible to add a test for this feature?

[anncwb]

@anncwb this looks good, thanks!

Would it be possible to add a test for this feature?

For plugin-legacy, I did not expect good test cases. Only part of the playground example can be added.

[terry-au]

Not sure how to test cases where a custom bundle output is defined. Is it possible to have different configurations between tests? In any case, I've written a test to ensure the default chunk naming setup works as expected.

From 4e014ceabce1535cbb7860e2a0dfcee3b679e685 Mon Sep 17 00:00:00 2001
From: Terry Lewis <[email protected]>
Date: Fri, 21 May 2021 09:34:07 +1000
Subject: [PATCH] test(playground): add test for legacy bundle name generation

---
 .../legacy/__tests__/legacy.spec.ts           | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/packages/playground/legacy/__tests__/legacy.spec.ts b/packages/playground/legacy/__tests__/legacy.spec.ts
index 0a9a2148..008a07eb 100644
--- a/packages/playground/legacy/__tests__/legacy.spec.ts
+++ b/packages/playground/legacy/__tests__/legacy.spec.ts
@@ -12,3 +12,22 @@ test('import.meta.env.LEGACY', async () => {
 test('transpiles down iterators correctly', async () => {
   expect(await page.textContent('#iterators')).toMatch('hello')
 })
+
+test('generates chunk names with hashes', async () => {
+  // we're only supporting legacy in prod,
+  // so we skip this test when isBuild is false
+  if (!isBuild) return
+
+  const scriptTags = await page.$$('//html/body/script')
+  expect(scriptTags).toHaveLength(3)
+
+  const [, polyfills, systemJSScriptSrc] = scriptTags
+
+  expect(await polyfills.getAttribute('src')).toEqual(
+    expect.stringMatching(/^\/assets\/polyfills-legacy.[a-zA-Z0-9]+.js$/)
+  )
+
+  expect(await systemJSScriptSrc.getAttribute('data-src')).toEqual(
+    expect.stringMatching(/^\/assets\/index-legacy.[a-zA-Z0-9]+.js$/)
+  )
+})
-- 
2.30.1 (Apple Git-130)