Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): improve ESBuildOptions.include / exclude type to allow readonly (string | RegExp)[] #19146

Merged

Conversation

@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Jan 7, 2025
@sapphi-red sapphi-red added this to the 6.1 milestone Jan 7, 2025
@sapphi-red sapphi-red changed the title feat(types): extending the ESBuildOptions type feat(types): improve ESBuildOptions.include / exclude type to allow readonly (string | RegExp)[] Jan 7, 2025
@bluwy
Copy link
Member

bluwy commented Jan 7, 2025

I was thinking this could be a fix and released as a patch, since it feels like an oversight to me that it's not (string | RegExp)[] like all of our other types.

@sapphi-red
Copy link
Member

sapphi-red commented Jan 7, 2025

I'm fine with releasing this as a patch, too. Let's merge this if the ecosystem-ci is ok 👍

@sapphi-red
Copy link
Member

/ecosystem-ci run

Copy link

pkg-pr-new bot commented Jan 7, 2025

Open in Stackblitz

npm i https://pkg.pr.new/vite@19146

commit: 02e59ff

@vite-ecosystem-ci
Copy link

@sapphi-red sapphi-red removed this from the 6.1 milestone Jan 7, 2025
@sapphi-red
Copy link
Member

ecosystem-ci seems ok

@sapphi-red sapphi-red changed the title feat(types): improve ESBuildOptions.include / exclude type to allow readonly (string | RegExp)[] fix(types): improve ESBuildOptions.include / exclude type to allow readonly (string | RegExp)[] Jan 7, 2025
@sapphi-red sapphi-red added p2-edge-case Bug, but has workaround or limited in scope (priority) and removed p2-nice-to-have Not breaking anything but nice to have (priority) labels Jan 7, 2025
@sapphi-red sapphi-red merged commit ea53e70 into vitejs:main Jan 7, 2025
21 checks passed
@btea btea deleted the feat/esbuild-extend-include-exclude-type branch January 7, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-edge-case Bug, but has workaround or limited in scope (priority) trigger: preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants