Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc & comment conflict] document and comments about build.target are a little confused #19034

Closed
7 tasks done
zhaojjiang opened this issue Dec 21, 2024 · 1 comment · Fixed by #19047
Closed
7 tasks done
Labels
documentation Improvements or additions to documentation p1-chore Doesn't change code behavior (priority)

Comments

@zhaojjiang
Copy link

Describe the bug

about build.target

The document shows

https://vite.dev/guide/build.html#browser-compatibility

Note that by default, Vite only handles syntax transforms and does not cover polyfills.

But the code comment shows except for dynamic import

* and the lowest supported target is es2015/es6. Note this only handles
* syntax transformation and does not cover polyfills (except for dynamic
* import)

A few days ago, we found dynamic-imports compatibility error, so I tried to found more info about the difference bwtween build.target and @vitejs/plugin-legacy, and then found there are some conflict description.

The comment was added since 4 years ago, maybe it is outdated?

Reproduction

document & code comment

Steps to reproduce

No response

System Info

system independent

Used Package Manager

npm

Logs

No response

Validations

@sapphi-red
Copy link
Member

Yeah, the code comment is outdated.

@sapphi-red sapphi-red added documentation Improvements or additions to documentation p1-chore Doesn't change code behavior (priority) and removed pending triage labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants