Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hmr): pass id in parseImports for better debugging DX #15707

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

antfu
Copy link
Member

@antfu antfu commented Jan 24, 2024

Description

When the source get syntax errors, we see error message like this:

image

The random @ comes from the default value of es-module-lexer: https://github.com/guybedford/es-module-lexer/blob/c357368bd4681011bc938ec54d48b2c6a969672b/src/lexer.ts#L156

We should provide correct file name for easier to understand what's goes wrong.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Jan 24, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev merged commit fb4bddc into main Jan 24, 2024
10 checks passed
@patak-dev patak-dev deleted the chore/pass-id-parse branch January 24, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants