Vite does not bundle dependencies of modules imported via ?url suffix

[WaldemarLehner]

Describe the bug

I have created a Mono-Repo with a Library and a Vite-Frontend consuming said Library.

The Library contains a module I import into the Frontend using the ?url suffix to get the Module URL — as a result the module get added to the dist/assets directory, as expected.

I expect Vite to also include any dependencies the ?url-imported Module might contain.

Vite however does not copy over the ?url-imported Module's dependencies.

Reproduction

https://github.com/WaldemarLehner/vite-url-import-issue-repo

Steps to reproduce

Inside the project root, run npm i

Run npm run build. This will build both animations and vite-frontend.

Run npm run host. This will create a local server on Port 1234 serving packages/vite-frontend/dist.

You should see an Element with the Message An error occurred while loading the animation..
Opening the Console, you will see that GET http://localhost:1234/assets/makeScene2D-d2e6cdaa.js has failed.

Stop the Server and run npm run copy-makeScene2D. This will simply copy the file from packages/animations/dist/makeScene2D-... to packages/vite-frontend/dist/assets.

Restart the Server with npm run host.
A primitive animation should be playable.

System Info

System:
    OS: Linux 6.6 Arch Linux
    CPU: (12) x64 AMD Ryzen 5 3600X 6-Core Processor
    Memory: 19.42 GB / 31.27 GB
    Container: Yes
    Shell: 5.9 - /usr/bin/zsh
  Binaries:
    Node: 20.8.0 - ~/.nvm/versions/node/v20.8.0/bin/node
    npm: 10.1.0 - ~/.nvm/versions/node/v20.8.0/bin/npm
  Browsers:
    Chromium: 120.0.6099.109
  npmPackages:
    vite: ^5.0.10 => 5.0.10

Used Package Manager

npm

Logs

Click to expand!

> [email protected] build
> tsc && vite build --debug

  vite:config bundled config file loaded in 12.50ms +0ms
  vite:config using resolved config: {
  vite:config   build: {
  vite:config     target: [ 'es2020', 'edge88', 'firefox78', 'chrome87', 'safari14' ],
  vite:config     cssTarget: [ 'es2020', 'edge88', 'firefox78', 'chrome87', 'safari14' ],
  vite:config     outDir: 'dist',
  vite:config     assetsDir: 'assets',
  vite:config     assetsInlineLimit: 0,
  vite:config     cssCodeSplit: true,
  vite:config     sourcemap: false,
  vite:config     rollupOptions: {},
  vite:config     minify: 'esbuild',
  vite:config     terserOptions: {},
  vite:config     write: true,
  vite:config     emptyOutDir: null,
  vite:config     copyPublicDir: true,
  vite:config     manifest: false,
  vite:config     lib: false,
  vite:config     ssr: false,
  vite:config     ssrManifest: false,
  vite:config     ssrEmitAssets: false,
  vite:config     reportCompressedSize: true,
  vite:config     chunkSizeWarningLimit: 500,
  vite:config     watch: null,
  vite:config     commonjsOptions: { include: [Array], extensions: [Array] },
  vite:config     dynamicImportVarsOptions: { warnOnError: true, exclude: [Array] },
  vite:config     modulePreload: { polyfill: true },
  vite:config     cssMinify: true
  vite:config   },
  vite:config   optimizeDeps: {
  vite:config     disabled: 'build',
  vite:config     force: undefined,
  vite:config     esbuildOptions: { preserveSymlinks: false }
  vite:config   },
  vite:config   configFile: '/media/projects/2024-Q1/astro-motion-canvas-import-issues-repro/packages/vite-frontend/vite.config.ts',
  vite:config   configFileDependencies: [
  vite:config     '/media/projects/2024-Q1/astro-motion-canvas-import-issues-repro/packages/vite-frontend/vite.config.ts'
  vite:config   ],
  vite:config   inlineConfig: {
  vite:config     root: undefined,
  vite:config     base: undefined,
  vite:config     mode: undefined,
  vite:config     configFile: undefined,
  vite:config     logLevel: undefined,
  vite:config     clearScreen: undefined,
  vite:config     optimizeDeps: { force: undefined },
  vite:config     build: {}
  vite:config   },
  vite:config   root: '/media/projects/2024-Q1/astro-motion-canvas-import-issues-repro/packages/vite-frontend',
  vite:config   base: '/',
  vite:config   rawBase: '/',
  vite:config   resolve: {
  vite:config     mainFields: [ 'browser', 'module', 'jsnext:main', 'jsnext' ],
  vite:config     conditions: [],
  vite:config     extensions: [
  vite:config       '.mjs',  '.js',
  vite:config       '.mts',  '.ts',
  vite:config       '.jsx',  '.tsx',
  vite:config       '.json'
  vite:config     ],
  vite:config     dedupe: [],
  vite:config     preserveSymlinks: false,
  vite:config     alias: [ [Object], [Object] ]
  vite:config   },
  vite:config   publicDir: '/media/projects/2024-Q1/astro-motion-canvas-import-issues-repro/packages/vite-frontend/public',
  vite:config   cacheDir: '/media/projects/2024-Q1/astro-motion-canvas-import-issues-repro/packages/vite-frontend/node_modules/.vite',
  vite:config   command: 'build',
  vite:config   mode: 'production',
  vite:config   ssr: {
  vite:config     target: 'node',
  vite:config     optimizeDeps: { disabled: true, esbuildOptions: [Object] }
  vite:config   },
  vite:config   isWorker: false,
  vite:config   mainConfig: null,
  vite:config   isProduction: true,
  vite:config   plugins: [
  vite:config     'vite:build-metadata',
  vite:config     'vite:watch-package-data',
  vite:config     'vite:pre-alias',
  vite:config     'alias',
  vite:config     'vite:modulepreload-polyfill',
  vite:config     'vite:resolve',
  vite:config     'vite:html-inline-proxy',
  vite:config     'vite:css',
  vite:config     'vite:esbuild',
  vite:config     'vite:json',
  vite:config     'vite:wasm-helper',
  vite:config     'vite:worker',
  vite:config     'vite:asset',
  vite:config     'vite:wasm-fallback',
  vite:config     'vite:define',
  vite:config     'vite:css-post',
  vite:config     'vite:build-html',
  vite:config     'vite:worker-import-meta-url',
  vite:config     'vite:asset-import-meta-url',
  vite:config     'vite:force-systemjs-wrap-complete',
  vite:config     'commonjs',
  vite:config     'vite:data-uri',
  vite:config     'vite:dynamic-import-vars',
  vite:config     'vite:import-glob',
  vite:config     'vite:build-import-analysis',
  vite:config     'vite:esbuild-transpile',
  vite:config     'vite:terser',
  vite:config     'vite:reporter',
  vite:config     'vite:load-fallback'
  vite:config   ],
  vite:config   css: { lightningcss: undefined },
  vite:config   esbuild: { jsxDev: false },
  vite:config   server: {
  vite:config     preTransformRequests: true,
  vite:config     sourcemapIgnoreList: [Function: isInNodeModules$1],
  vite:config     middlewareMode: false,
  vite:config     fs: {
  vite:config       strict: true,
  vite:config       allow: [Array],
  vite:config       deny: [Array],
  vite:config       cachedChecks: false
  vite:config     }
  vite:config   },
  vite:config   preview: {
  vite:config     port: undefined,
  vite:config     strictPort: undefined,
  vite:config     host: undefined,
  vite:config     https: undefined,
  vite:config     open: undefined,
  vite:config     proxy: undefined,
  vite:config     cors: undefined,
  vite:config     headers: undefined
  vite:config   },
  vite:config   envDir: '/media/projects/2024-Q1/astro-motion-canvas-import-issues-repro/packages/vite-frontend',
  vite:config   env: { BASE_URL: '/', MODE: 'production', DEV: false, PROD: true },
  vite:config   assetsInclude: [Function: assetsInclude],
  vite:config   logger: {
  vite:config     hasWarned: false,
  vite:config     info: [Function: info],
  vite:config     warn: [Function: warn],
  vite:config     warnOnce: [Function: warnOnce],
  vite:config     error: [Function: error],
  vite:config     clearScreen: [Function: clearScreen],
  vite:config     hasErrorLogged: [Function: hasErrorLogged]
  vite:config   },
  vite:config   packageCache: Map(1) {
  vite:config     'fnpd_/media/projects/2024-Q1/astro-motion-canvas-import-issues-repro/packages/vite-frontend' => {
  vite:config       dir: '/media/projects/2024-Q1/astro-motion-canvas-import-issues-repro/packages/vite-frontend',
  vite:config       data: [Object],
  vite:config       hasSideEffects: [Function: hasSideEffects],
  vite:config       webResolvedImports: {},
  vite:config       nodeResolvedImports: {},
  vite:config       setResolvedCache: [Function: setResolvedCache],
  vite:config       getResolvedCache: [Function: getResolvedCache]
  vite:config     },
  vite:config     set: [Function (anonymous)]
  vite:config   },
  vite:config   createResolver: [Function: createResolver],
  vite:config   worker: { format: 'iife', plugins: '() => plugins', rollupOptions: {} },
  vite:config   appType: 'spa',
  vite:config   experimental: { importGlobRestoreExtension: false, hmrPartialAccept: false },
  vite:config   getSortedPlugins: [Function: getSortedPlugins],
  vite:config   getSortedPluginHooks: [Function: getSortedPluginHooks]
  vite:config } +16ms
vite v5.0.10 building for production...
✓ 149 modules transformed.
dist/index.html                      0.46 kB │ gzip:  0.29 kB
dist/assets/animation1-nlMJSs-z.js   1.40 kB
dist/assets/index-s-MxoWxy.css       1.21 kB │ gzip:  0.63 kB
dist/assets/index-Usikbq5D.js       60.06 kB │ gzip: 14.84 kB
✓ built in 523ms

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[XiSenao]

Under the premise of this issue, it seems that vite will handle the modules imported from ?url as asset resources, which can be seen as a replication behavior rather than a packaging behavior.

Here is a simple hack to bypass the behavior of ?url, not recommended.

// build `animations/dist/animation1` module.
const modules = import.meta.glob(['animations/dist/animation1']);

// get the path of the built module.
const importPathRegex = /import\(['"]([^'"]+)['"]\)/;
const importStatement = Object.values(modules)[0].toString();  
const match = importStatement.match(importPathRegex);
let sourceUrl = '';
if (match) {
  const path = match[1];
  sourceUrl = path;
}

[sapphi-red]

Duplicate of #6757