SVG data-url built with errors

[Poyoman39]

Describe the bug

• I'm using vite with react
• I'm using background-image: url('./someFile.svg'); inside a someFile.module.scss
• The svg is converted to a data uri at build time
• The data uri contains error a build time

The bug happens when an svg attribute contains an apostrophe '. in my case i had a <g data-name="some d'ata name"></g>

Reproduction

https://stackblitz.com/edit/vitejs-vite-ifrcfk?file=javascript.svg

Steps to reproduce

You wont see the issue on the reproduction url since it's "dev time" and not after build

• Build any project with an svg containing data-name="some d'ata name"

• Then with vite preview for instance, you can see the svg is not rendered and contains an error

• Built svg has this => data-name='some d'ata name' (apostrophe is not escaped)

System Info

System:
    OS: Linux 6.6 EndeavourOS
    CPU: (16) x64 AMD Ryzen 9 5900HS with Radeon Graphics
    Memory: 18.77 GB / 30.76 GB
    Container: Yes
    Shell: 5.9 - /usr/bin/zsh
  Binaries:
    Node: 20.10.0 - /usr/bin/node
    npm: 10.2.4 - /usr/bin/npm
    bun: 1.0.14 - ~/.bun/bin/bun
  Browsers:
    Chromium: 120.0.6099.62
  npmPackages:
    @vitejs/plugin-react-swc: ^3.5.0 => 3.5.0 
    vite: ^5.0.6 => 5.0.6

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[stackblitz]

Start a new pull request in StackBlitz Codeflow.

• vitejs-vite-ifrcfk (Open reproduction)

[bluwy]

The SVG data uri minifier we have didn't quite anticipated single quotes within attribute values. We currently transform all double quotes as single quotes. Maybe the fix is to detect "...'..." an pre-escape them.