feat: add import-meta.d.ts #14615
Merged
feat: add import-meta.d.ts #14615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
added
the
p2-nice-to-have
patak-dev
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
I think the comment you made is enough if we choose this path. Hopefully, the issue will be resolved in TS and we can remove this later in a future major.
Astro (and others) will move to import-meta, and then later again need to move to importMeta (the other option would be to later delete importMeta instead). But maybe it is an ok price to pay for keeping the casing consistent with other files in the long term.
|
Yeah I think we can keep |
sapphi-red
approved these changes
Oct 14, 2023
|
I'll merge this for now since it's less controversial. I'm not a huge fan either but TypeScript 😬 |
9 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #13309
Non-breaking alternative to #14279
This adds
types/imports-meta.d.tsthat only proxiestypes/importMeta.d.ts. I tested locally and it seems to work in macos, but I'm not sure if it works for Linux. But from what I understand, the casing issue only affects<reference typesnot<reference path.Additional context
Only added this one file for now, if there's more request, we can add for the others.
Also, should we mark this file as internal/experimental? (e.g. just a comment)
What is the purpose of this pull request?