-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: deprecate cjs node api #14278
Conversation
Run & review this pull request in StackBlitz Codeflow. |
That should make TS error with something like |
Would it work if we wrote it like this? It'd be nice to show it with a strikethrough. /**
* @deprecate Vite CJS Node API deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.
*/
declare const module: any
export = module |
I’m not sure. Worth a try. A deprecated |
Description
VITE_CJS_TRACE
flag to useconsole.trace
when logging the warning.fix #11552
Additional context
@andrewbranch, just confirming, is this PR making the right change to fix Vite's CJS types? I created an empty
index.d.cts
for CJS exports.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).