Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a close button to HMR overlay for screen reader accessibility #13748

Closed
4 tasks done
yncat opened this issue Jul 8, 2023 · 2 comments · Fixed by #13795
Closed
4 tasks done

Add a close button to HMR overlay for screen reader accessibility #13748

yncat opened this issue Jul 8, 2023 · 2 comments · Fixed by #13795
Labels

Comments

@yncat
Copy link

yncat commented Jul 8, 2023

Description

Summary

As a developer, I want a workable way of dismissing the HMR overlay with a screen reader.

Problem

When there is an error or warning in my project and the HMR overlay appears, I cannot dismiss the dialog.

Reason

I am using a screen reader. I cannot "click outside" as the dialog suggests.

Suggested solution

Proposed Solution

One or all of these.

  • Add "dismiss" button so that I can press the button and close the dialog
  • Allow the escape key to dismiss the dialog

Alternative

server.hmr.overlay = false exists, but this is not a perfect solution because:

  • It cannot be applied for collaborating projects because it affects everyone else
  • the difficulty for dismissing the dialog itself is the root of the problem, and avoiding it just by a hack is not ideal

Additional context

Notes

I am using vite in one of the projects as a collaborator. Vite version is 4.1.1. Sorry if the problem is already solved in newer versions.

Validations

@bluwy
Copy link
Member

bluwy commented Jul 10, 2023

I think having an esc shortcut would be nice to have.

@yncat
Copy link
Author

yncat commented Jul 11, 2023

Yes, that would be enough. Agreed!

@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants