fix(esbuild): use useDefineForClassFields: false
when no compilerOptions.target
is declared
#13708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
esbuild seems to use
useDefineForClassFields: true
whentarget
isn't declared in tsconfig. (TypeScript usesuseDefineForClassFields: false
in that case)https://esbuild.github.io/try/#dAAwLjE4LjExAC0tbG9hZGVyPXRzICctLXRzY29uZmlnLXJhdz17ImNvbXBpbGVyT3B0aW9ucyI6e319JwBjbGFzcyBGb28gewogIGZvbyA9ICdmb28nCn0
refs #13525
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).