feat(build): warn dynamic import module with a static import alongside #12850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fi3ework
commented
Apr 13, 2023
fi3ework
force-pushed
the
warn-ineffective-dynamic-import
branch
3 times, most recently
from
9b28228 to
eb95a3c
Compare
bluwy
reviewed
May 16, 2023
fi3ework
force-pushed
the
warn-ineffective-dynamic-import
branch
from
eb95a3c to
d16e2e2
Compare
bluwy
added
p2-nice-to-have
bluwy
reviewed
Jun 10, 2023
Comment on lines
127
to
139
| this.warn( | ||
| `\n(!) ${ | ||
| module.id | ||
| } is dynamically imported by ${module.dynamicImporters | ||
| .map((m) => m) | ||
| .join( | ||
| ', ', | ||
| )} but also statically imported by ${module.importers | ||
| .map((m) => m) | ||
| .join( | ||
| ', ', | ||
| )}, dynamic import will not move module into another chunk.\n`, | ||
| ) |
There was a problem hiding this comment.
Should we add a break after the this.warn here?
There was a problem hiding this comment.
👍🏻 Nice catch. Switched to using .some instead of a for loop (I start to know why it's hard to understand 😅)
bluwy
changed the title
4 tasks
9 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #12706. As @bluwy suggested, use rollup's warn to warn the ineffective dynamic import.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).