feat(create-vite): add eslint to React templates #12801
Conversation
|
|
ArnaudBarre
force-pushed
the
react-template-eslint
branch
from
14328e6
to
e2b4c3a
Compare
|
@cyco130 @nickmccurdy maybe you could help us with a review here |
|
@patak-dev I can, but I'm curious, has the Vite team's stance on lint configs changed? I thought they wouldn't be merged, or I would have suggested some myself. |
|
@nickmccurdy we discussed with the team after the discussion between you, Dan Abramov, and others, and we believe that for the particular case of React, Dan is correct, we need to include at least We would prefer to avoid adding eslint to the templates (and we don't have plans to add them to other frameworks), but for React, it seems we should do this. |
|
Have we considered using the new eslint config file https://eslint.org/docs/latest/use/configure/configuration-files-new or is it not mature enough? |
|
I've tried it but and it look nicer but the init command still generates the old output, and the total absence of types was really painful to migrate manually, after hitting three runtime errors when updating the config I gave up. But I'm open to contribution for that. |
| 'plugin:react-hooks/recommended', | ||
| ], | ||
| parserOptions: { ecmaVersion: 'latest', sourceType: 'module' }, | ||
| settings: { react: { version: '18.2' } }, |
There was a problem hiding this comment.
You could use "detect" as version value and never change this line again in your lifetime
There was a problem hiding this comment.
Personally I think the complexity of resolutions involved in web dev is higher than the chance of a rule targeting a version of React not yet released.
There was a problem hiding this comment.
@ArnaudBarre i think this is more about if you update the installed react version to 19, it would still apply '18.2' settings unless you remember to update this version string too, which renovate-bot et al won't do for you.
There was a problem hiding this comment.
Yeah I know but if it get out of sync this is probably not an issue. You will maybe after sometimes "miss" some lint rules that advice for new APIs (if they exist and if someone make a rule for that).
This is why this not an issue for me and using "detect" IMO will cause more issue because of the overall complexity to be able to resolve "react" given the varierty of runtimes and package manager available
There was a problem hiding this comment.
from what I understood, eslint was added here because it is considered essential for react templates, to the point that it would be broken without it? Honestly I disagree with that view and would have preferred that all create-vite templates stayed the same minimal "show it works" style.
But if this is truly needed, using the settings for the correct react version is essential too and they need to take care of resolving it correctly in the eslint plugin.
The alternative would be to disable renovate updates for react and additional maintenace burden to update both manually. Oh, and you'd have to pin the react version in package.json.
|
Thank you for adding eslint! I just can't configure on my own. There's just too many opinions out there. Does anyone know a quick way to add this to old projects. I have to copy the packages and |
No description provided.