Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): watch config even outside of root #12321

Merged
merged 1 commit into from
Mar 7, 2023
Merged

fix(config): watch config even outside of root #12321

merged 1 commit into from
Mar 7, 2023

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented Mar 7, 2023

Description

a repro: https://stackblitz.com/edit/vitejs-vite-cv8sdt?file=vite.config.ts,package.json&terminal=dev. Modify vite.config.ts and the server will not restart (Ideally it should).

When config file and its deps are out of resolvedConfig.root, it won't be watched.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Mar 7, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev
Copy link
Member

Thanks for the PR @fi3ework! Would you update the title? Looks like it got one of your prev PR.

@fi3ework fi3ework changed the title fix: handle error without line and column in loc fix(config): watch config even outside of root Mar 7, 2023
@fi3ework
Copy link
Member Author

fi3ework commented Mar 7, 2023

Thanks for the PR @fi3ework! Would you update the title? Looks like it got one of your prev PR.

@patak-dev 😅 An embarrassing mistake, updated.

@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Mar 7, 2023
@bluwy bluwy merged commit 7e2fff7 into vitejs:main Mar 7, 2023
@fi3ework fi3ework deleted the watch-config-out-of-root branch March 7, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fi3ework @patak-dev @bluwy