Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(optimizer): don not call context.rebuild after cancel #12264

Merged
merged 3 commits into from
Mar 2, 2023
Merged

fix(optimizer): don not call context.rebuild after cancel #12264

merged 3 commits into from
Mar 2, 2023

Conversation

patak-dev
Copy link
Member

Description

Bail out earlier in scanImports and optimizeDeps if the process was cancelled.

Possible fix for https://github.com/vitejs/vite-ecosystem-ci/actions/runs/4305319550/jobs/7507584043

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@stackblitz
Copy link

stackblitz bot commented Mar 2, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev requested a review from bluwy March 2, 2023 10:16
@patak-dev
Copy link
Member Author

/ecosystem-ci run astro

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Mar 2, 2023 •
edited
Loading

📝 Ran ecosystem CI: Open

suite result
astro ✅ success

bluwy
bluwy reviewed Mar 2, 2023
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! There's a couple of typos below which we could fix.

packages/vite/src/node/optimizer/index.ts Outdated Show resolved Hide resolved
packages/vite/src/node/optimizer/scan.ts Outdated Show resolved Hide resolved
patak-dev and others added 2 commits March 2, 2023 12:38
@patak-dev patak-dev merged commit 520d84e into main Mar 2, 2023
@patak-dev patak-dev deleted the fix/optimizer-do-not-rebuild-after-cancel branch March 2, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patak-dev @bluwy