fix(cli): exit 1 on ctrl+c #11563
Merged
fix(cli): exit 1 on ctrl+c #11563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenfan0
reviewed
Jan 3, 2023
7 tasks
ArnaudBarre
added
the
p2-to-be-discussed
ArnaudBarre
force-pushed
the
fix-ctrl-c
branch
from
20d528b
to
ba15581
Compare
ArnaudBarre
removed
the
p2-to-be-discussed
|
@patak-dev Updated and tested. You get double "exit error 1" command when running |
patak-dev
approved these changes
Jan 26, 2023
futurGH
pushed a commit
to futurGH/vite
that referenced
this pull request
Feb 26, 2023
7 tasks
This was referenced Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be the only option to enable both shortcuts and exiting vite running via
npm-run-allwith default options in onectrl+c.The bad part is that when running vite via
yarnorpnpm, you get an extra error on exit:When using
npm-run-all, it logs:ERROR: "dev" exited with 1.The other option is to not fix the issue. I suggested multiple way to "workaround" the issue: #11434 (comment)
For information, vitest is exiting is code 0 which is subject to the same issue (but probably people don't use vitest watch mode along other watch process)
Re: #11518 #11562