Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(create-vite): added transition to grow back drop in #11392

Merged
merged 1 commit into from
Dec 17, 2022
Merged

chore(create-vite): added transition to grow back drop in #11392

merged 1 commit into from
Dec 17, 2022

Conversation

Hexy32
Copy link
Contributor

@Hexy32 Hexy32 commented Dec 16, 2022 •
edited
Loading

Description

Added a transition to the back drop so it fades in/grows nicely, videos of what it looks like below:

with-transition.mov
without-transition.mov

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

bluwy
bluwy approved these changes Dec 17, 2022
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice change for me

@patak-dev patak-dev merged commit d0757e2 into vitejs:main Dec 17, 2022
@Hexy32 Hexy32 deleted the smooth-transition branch December 17, 2022 16:23
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@Hexy32 @futurGH
chore(create-vite): added transition to grow back drop in (vitejs#11392)
659fbec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hexy32 @bluwy @patak-dev