chore(create-vite): align vue template with create-vue #11128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Haoqun Jiang <[email protected]>
sapphi-red
commented
Nov 30, 2022
Comment on lines
-2
to
-3
| // This starter template is using Vue 3 <script setup> SFCs | ||
| // Check out https://vuejs.org/api/sfc-script-setup.html#script-setup |
There was a problem hiding this comment.
I think we can remove this.
This is written in README and <script setup> is released more than a year ago. (2021/08)
sapphi-red
commented
Nov 30, 2022
Comment on lines
-3
to
-7
| declare module '*.vue' { | ||
| import type { DefineComponent } from 'vue' | ||
| const component: DefineComponent<{}, {}, any> | ||
| export default component | ||
| } |
There was a problem hiding this comment.
This is handled by typescript-vue-plugin or Volar's take over mode.
patak-dev
approved these changes
Nov 30, 2022
9 tasks
futurGH
pushed a commit
to futurGH/vite
that referenced
this pull request
Feb 26, 2023
Co-authored-by: Haoqun Jiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated vue templates to align with create-vue.
https://github.com/vuejs/create-vue-templates/tree/542b43b05c8548ba100f6147e89b448de1d574e8/default
https://github.com/vuejs/create-vue-templates/tree/542b43b05c8548ba100f6147e89b448de1d574e8/typescript
close #9136 (
declare module '*.vue'is removed)Additional context
I added @sodatea to co-author as the README text is copied from create-vue. Should I add a license somewhere too?
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).