Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expose server as Http2SecureServer type #10196

Merged
merged 8 commits into from
Oct 20, 2022
Merged

fix: expose server as Http2SecureServer type #10196

merged 8 commits into from
Oct 20, 2022

Conversation

PengBoUESTC
Copy link
Contributor

Description

add Http2SecureServer type for vite server

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • [] Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy changed the title chore: http server type fix: expose server as Http2SecureServer type Sep 23, 2022
patak-dev
patak-dev reviewed Oct 14, 2022
View reviewed changes
packages/vite/src/node/server/middlewares/compression.ts Outdated
@@ -41,6 +41,7 @@ export default function compression() {
let pendingListeners = []
let started = false
let size = 0
const { end, write, on, writeHead } = res
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is unrelated to the PR, would you revert it?

@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Oct 14, 2022 •
edited
Loading

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
histoire ✅ success
iles ✅ success
ladle ✅ success
laravel ✅ success
marko ❌ failure
nuxt-framework ✅ success
rakkas ✅ success
svelte ✅ success
vite-plugin-ssr ✅ success
vite-setup-catalogue ✅ success
vitepress ❌ failure
vitest ✅ success
windicss ✅ success

@PengBoUESTC PengBoUESTC requested a review from patak-dev October 14, 2022 09:51
@PengBoUESTC
Copy link
Contributor Author

Is there anything else to optimize? @patak-dev

@patak-dev patak-dev added this to the 3.2 milestone Oct 19, 2022
@patak-dev patak-dev added the p2-nice-to-have Not breaking anything but nice to have (priority) label Oct 19, 2022
@patak-dev patak-dev merged commit f328f61 into vitejs:main Oct 20, 2022
@PengBoUESTC
Copy link
Contributor Author

Thanks! ^ _ ^

patak-dev added a commit that referenced this pull request Oct 21, 2022
@patak-dev
chore: revert #10196 until Vite 4
d2dd940 
This reverts commit f328f61.
@patak-dev patak-dev mentioned this pull request Oct 21, 2022
Merged
4 tasks
patak-dev added a commit that referenced this pull request Oct 21, 2022
@patak-dev
chore: revert #10196 until Vite 4 (#10574)
07c0336 
This reverts commit f328f61.
@PengBoUESTC PengBoUESTC deleted the feature/http-server-type branch January 11, 2023 02:10
@bluwy bluwy mentioned this pull request Nov 2, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@PengBoUESTC @patak-dev @sapphi-red @haoqunjiang