Internal defines plugin conflict with Vite/Hono fullstack bundler & dev server

[impaler]

Hi was trying@hono/vite-build which enables you to use Vite for the server and client code and make use of the single Vite dev server. Its rather nice that it lets you create something with minimal boilerplate in Vite, similar to the new Bun fullstack dev server.

In the server code, I noticed you cannot use process.env as Vite has the internal defines plugin to replace it with static values. honojs/vite-plugins#222.

This doesn't make sense for the server, as the environment variables are usually used for configurability and providing secrets etc at runtime.

Anyone know a way to configure Vite's default behaviour for defines? Seems like it doesn't happen in library mode. Also it doesn't looks like there is a clear plugin api to modify the internal Vite plugins for situations like this, just the user config.

Is the approach Hono is currently taking with the plugin api just a new use case for Vite?

I can only think of imperfect workarounds, perhaps the approach of the Hono plugin is missing something altogether and the lib mode should be used for other reasons aswell, since it targets the server and not a "browser client"?

[hi-ogawa]

process.env should be preserved for ssr build by default https://stackblitz.com/edit/vitejs-vite-z3pm1ueu?file=vite.config.ts, so I'd suspect this might be Hono's vite config issue (or intended to be replaced as build time define for edge runtime without process?)

[impaler]

@hi-ogawa thanks for the insights, here is the issue https://stackblitz.com/edit/vitejs-vite-brbdcvxm?file=vite.config.ts%3AL24-L24
you maybe correct about hono plugin making assumptions about edge runtime constraints, they support them as well as node. Its not obvious to me in the plugin if thats true, debugging configResolved shows build.ssr is true.

[impaler]

A config solution was found by @hi-ogawa here honojs/vite-plugins#222 (comment)