Skip to content

Commit

Permalink
fixup! feat: enable dependencies discovery and pre-bundling in ssr en…
Browse files Browse the repository at this point in the history
…viroments

add pre-bundling testing to environment-react-ssr
  • Loading branch information
dario-piotrowicz committed Oct 17, 2024
1 parent 3441649 commit ec7f400
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 1 deletion.
25 changes: 25 additions & 0 deletions playground/environment-react-ssr/__tests__/pre-bundling.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import type { DepOptimizationMetadata } from 'vite'
import { expect, test } from 'vitest'
import { isBuild, readFile } from '~utils'

test.runIf(!isBuild)('client - metadata', async () => {
const meta = await readFile('node_modules/.vite/deps/_metadata.json')
const metaJson: DepOptimizationMetadata = JSON.parse(meta)

expect(metaJson.optimized['react']).toBeTruthy()
expect(metaJson.optimized['react-dom/client']).toBeTruthy()
expect(metaJson.optimized['react/jsx-dev-runtime']).toBeTruthy()

expect(metaJson.optimized['react-dom/server']).toBeFalsy()
})

test.runIf(!isBuild)('ssr - metadata', async () => {
const meta = await readFile('node_modules/.vite/deps_ssr/_metadata.json')
const metaJson: DepOptimizationMetadata = JSON.parse(meta)

expect(metaJson.optimized['react']).toBeTruthy()
expect(metaJson.optimized['react-dom/server']).toBeTruthy()
expect(metaJson.optimized['react/jsx-dev-runtime']).toBeTruthy()

expect(metaJson.optimized['react-dom/client']).toBeFalsy()
})
2 changes: 1 addition & 1 deletion playground/environment-react-ssr/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"version": "0.0.0",
"type": "module",
"scripts": {
"dev": "vite",
"dev": "vite --force",
"build": "vite build --app",
"preview": "vite preview"
},
Expand Down
5 changes: 5 additions & 0 deletions playground/environment-react-ssr/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@ export default defineConfig((env) => ({
},
},
ssr: {
dev: {
optimizeDeps: {
entries: ['./src/entry-server.tsx'],
},
},
build: {
outDir: 'dist/server',
// [feedback]
Expand Down

0 comments on commit ec7f400

Please sign in to comment.