Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore directive sourcemap error #369

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix: ignore directive sourcemap error #369

merged 1 commit into from
Sep 25, 2024

Conversation

sapphi-red
Copy link
Member

Description

The upstream issue was not resolved for a while, so adding a workaround.

close vitejs/vite#15012

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-has-workaround 🍰 Bug, but has workaround (priority) label Sep 25, 2024
@sapphi-red sapphi-red mentioned this pull request Sep 25, 2024
Merged
hi-ogawa
hi-ogawa approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ArnaudBarre ArnaudBarre merged commit d88c581 into main Sep 25, 2024
7 checks passed
@ArnaudBarre ArnaudBarre deleted the chore/ignore-directive-source-map-error branch September 25, 2024 08:06
@1natsu172 1natsu172 mentioned this pull request Sep 29, 2024
Closed
5 tasks
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Sep 30, 2024
@renovate
Update dependency @vitejs/plugin-react to v4.3.2
3b2120a 
| datasource | package              | from  | to    |
| ---------- | -------------------- | ----- | ----- |
| npm        | @vitejs/plugin-react | 4.3.1 | 4.3.2 |


## [v4.3.2](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#432-2024-09-29)

Ignore directive sourcemap error [#369](vitejs/vite-plugin-react#369)
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Sep 30, 2024
@renovate
Update dependency @vitejs/plugin-react to v4.3.2
47ba513 
| datasource | package              | from  | to    |
| ---------- | -------------------- | ----- | ----- |
| npm        | @vitejs/plugin-react | 4.3.1 | 4.3.2 |


## [v4.3.2](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#432-2024-09-29)

Ignore directive sourcemap error [#369](vitejs/vite-plugin-react#369)
@tristanrobert tristanrobert mentioned this pull request Oct 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hi-ogawa hi-ogawa hi-ogawa approved these changes

Assignees
No one assigned
Labels
p2-has-workaround 🍰 Bug, but has workaround (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lots of warnings when building project with Vite 5, Material UI and sourcemaps enabled
3 participants
@sapphi-red @hi-ogawa @ArnaudBarre