Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: cache load plugin #141

Merged
merged 1 commit into from
Apr 4, 2023
Merged

perf: cache load plugin #141

merged 1 commit into from
Apr 4, 2023

Conversation

sapphi-red
Copy link
Member

Description

It seems node calls importModuleDynamicallyCallback everytime import is called.
By caching this call, it reduced the start up time of https://github.com/sapphi-red/performance-compare from ~5100ms to ~4700ms.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-nice-to-have 🍰 Not breaking anything but nice to have (priority) label Apr 3, 2023
@ArnaudBarre ArnaudBarre merged commit fbf722f into main Apr 4, 2023
@sapphi-red sapphi-red deleted the perf/cache-load-plugin branch April 5, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have 🍰 Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants