feat: default esm SSR build, simplified externalization #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitejs-docs-ja ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
hiro-lapis
commented
Jun 18, 2022
| @@ -0,0 +1,7 @@ | |||
| import { defineConfig } from 'vite' | |||
There was a problem hiding this comment.
viteのバージョンが本家と異なるためなのかは分かりませんが、defineConfig内のオプション項目にssrがなくエラー表示されています。
↓このあたりについて本家でやりとりされている箇所
vitejs/vite#8348 (comment)
反映する必要があるのか判断に迷ったのですが、
本家の/docsは翻訳リポジトリのルートディレクトリなので対応範囲内なので、対応しました。
一応、yarn docs実行してのビルドエラーはなく、ページ表示も問題ないことは確認しました。
jay-es
reviewed
Jun 18, 2022
Co-authored-by: Jun Shindo <[email protected]>
|
@jay-es |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #466
vitejs/vite@f8c92d1 の反映です。
＊本家の変更の
packagesの対応はしていません。