From 6ac79eeaa2233b07551287226f57cdb9c187b25b Mon Sep 17 00:00:00 2001 From: userquin Date: Fri, 5 Apr 2024 18:20:55 +0200 Subject: [PATCH 1/2] fix: configure favicon preset when using inlined preset --- src/pwa-assets/config.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pwa-assets/config.ts b/src/pwa-assets/config.ts index 53238684..e1924f31 100644 --- a/src/pwa-assets/config.ts +++ b/src/pwa-assets/config.ts @@ -75,7 +75,7 @@ export async function loadAssetsGeneratorContext( imageResolver: () => readFile(imageFile), imageName, preset, - faviconPreset: userHeadLinkOptions?.preset, + faviconPreset: userHeadLinkOptions?.preset ?? pwaAssets.htmlPreset ?? '2023', htmlLinks: { xhtml, includeId }, basePath: pwaAssets.integration?.baseUrl || ctx.viteConfig.base || '/', resolveSvgName: userHeadLinkOptions?.resolveSvgName ?? (name => basename(name)), From 8c7f7feddae2f44b3a0212c73269fd8abe09428b Mon Sep 17 00:00:00 2001 From: userquin Date: Fri, 5 Apr 2024 18:30:18 +0200 Subject: [PATCH 2/2] chore: don't use 2023 when missing --- src/pwa-assets/config.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pwa-assets/config.ts b/src/pwa-assets/config.ts index e1924f31..055dd081 100644 --- a/src/pwa-assets/config.ts +++ b/src/pwa-assets/config.ts @@ -75,7 +75,7 @@ export async function loadAssetsGeneratorContext( imageResolver: () => readFile(imageFile), imageName, preset, - faviconPreset: userHeadLinkOptions?.preset ?? pwaAssets.htmlPreset ?? '2023', + faviconPreset: userHeadLinkOptions?.preset ?? pwaAssets.htmlPreset, htmlLinks: { xhtml, includeId }, basePath: pwaAssets.integration?.baseUrl || ctx.viteConfig.base || '/', resolveSvgName: userHeadLinkOptions?.resolveSvgName ?? (name => basename(name)),