Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updateServiceWorker doesn't trigger page reload since v0.19.1 #674

Closed
NicolaiHorlacher opened this issue Feb 29, 2024 · 2 comments · Fixed by #675
Closed

updateServiceWorker doesn't trigger page reload since v0.19.1 #674

NicolaiHorlacher opened this issue Feb 29, 2024 · 2 comments · Fixed by #675
Assignees
@userquin
Labels
bug Something isn't working

Comments

@NicolaiHorlacher
Copy link

I updated to version v0.19.1 and noticed that updateServiceWorker doesn't trigger a reload of the page anymore.
I checked the changes between v0.17.5 (last version I used) and noticed this condition was reversed.

vite-plugin-pwa/src/client/build/register.ts

Line 86 in 9652a0b

if (!event.isUpdate)

Maybe it got reversed by accident in #673?
@userquin userquin self-assigned this Feb 29, 2024
@userquin userquin added the bug Something isn't working label Feb 29, 2024
@userquin
Copy link
Member

upps

@userquin userquin mentioned this issue Feb 29, 2024
Merged
@userquin
Copy link
Member

@NicolaiHorlacher should be fixed in v0.19.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@userquin userquin

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: wrong changes reverting prompt logic vite-pwa/vite-plugin-pwa
2 participants
@userquin @NicolaiHorlacher