Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter encoding statements unnecessary. #8

Open
preston opened this issue Jun 16, 2015 · 1 comment
Open

Alter encoding statements unnecessary. #8

preston opened this issue Jun 16, 2015 · 1 comment

Comments

@preston
Copy link

preston commented Jun 16, 2015

Unless I'm missing something, all the execute(..) calls in the migrations are unneeded if you just set your database encoding correctly to start with. Plus, those types seems to be specific to MySQL and are b0rken on other databases. Works great on Postgres without them.

Thanks a ton for your efforts, and keep up the great work!

@jrissler
Copy link
Contributor

@preston Your 100% right. I can't remember why we had to add those at the time - but it's def covered by just setting encoding from the start now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants