Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

Why does visjs need an unique uuid library? #57

Open
Jogai opened this issue Feb 18, 2020 · 4 comments
Open

Why does visjs need an unique uuid library? #57

Jogai opened this issue Feb 18, 2020 · 4 comments

Comments

@Jogai
Copy link

Jogai commented Feb 18, 2020

Why not depend on one of these for example? https://github.com/grantcarthew/awesome-unique-id#generation

@Thomaash
Copy link
Member

To be honest I've never though about it. This is how it was when I came. Right now I can't think of any reason. Maybe @yotamberk or @mojoaxel would know about something?

Maybe we could switch to https://github.com/uuidjs/uuid (which implements the same RFC as we do here) as a part of visjs/vis-dev-utils#10 transition. I highly doubt many people, if anybody at all, depend on this directly so nobody will most likely care. It would be one package less to worry about.

@yotamberk
Copy link
Member

The short answer: There isn't a reason... At the time there was no good library for creating uuids so vis created a library for it. This can probably be removed and use a more common uuid generator

@Thomaash
Copy link
Member

Thanks for clarification. I'll purge it from the codebase then.

@mojoaxel
Copy link
Member

Thanks for clarification. I'll purge it from the codebase then.

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants