Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing { isDataViewLike } export in peer build #744

Closed
duckyb opened this issue Oct 21, 2020 · 1 comment
Closed

Missing { isDataViewLike } export in peer build #744

duckyb opened this issue Oct 21, 2020 · 1 comment

Comments

@duckyb
Copy link
Contributor

duckyb commented Oct 21, 2020

The latest vis-timeline build throws an error upon trying to serve our Angular app.

ERROR in ./node_modules/vis-timeline/peer/esm/vis-timeline-graph2d.js 22077:17-31
"export 'isDataViewLike' was not found in 'vis-data/peer/esm/vis-data.js'

I see that there is an included import for isDataViewLike in the build:

// vis-timeline/dist/peer/esm/vis-timeline.graph2d.js
import { DataSet, createNewDataPipeFrom, isDataViewLike, DataView } from 'vis-data/peer/esm/vis-data.js';

howerver, if I reverse-navigate the import path, I end up on entry-esnext.d.ts and there is no exported isDataViewLike:

// vis-data\declarations\entry-esnext.d.ts
export { DataInterface, DataInterfaceGetIdsOptions, DataInterfaceGetOptions, DataInterfaceGetOptionsArray, DataInterfaceGetOptionsObject, DataInterfaceMapOptions, DataInterfaceOrder, EventCallbacks, EventCallbacksWithAny, EventName, EventNameWithAny, TypeMap, Types, } from "./data-interface";
export * from "./data-pipe";
export { DataSet, DataSetOptions } from "./data-set";
export { DataStream } from "./data-stream";
export { DataView, DataViewOptions } from "./data-view";
export { Queue } from "./queue";
export { DELETE } from "vis-util/esnext";
// # sourceMappingURL=entry-esnext.d.ts.map

We were able to fix this error by changing "vis-timeline": "^7.3.6", to "vis-timeline": "7.3.6" but I thought I should still report this.

@yotamberk
Copy link
Member

you need to update vis-data module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants