Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): switch to uuid package #328

Merged
merged 2 commits into from
Feb 19, 2020
Merged

fix(deps): switch to uuid package #328

merged 2 commits into from
Feb 19, 2020

Conversation

Thomaash
Copy link
Member

This shouldn't be noticable from the outside at all.

This shouldn't be noticable from the outside at all.
@Thomaash Thomaash requested a review from yotamberk February 18, 2020 22:07
@yotamberk
Copy link
Member

examples seems to fail for some reason. Can you take a look?

yotamberk
yotamberk previously approved these changes Feb 19, 2020
@Thomaash
Copy link
Member Author

Hmm, it loads node.js files instead of those that would work in a browser.

Thomaash added a commit to visjs/vis-dev-utils that referenced this pull request Feb 19, 2020
We've never had combined node.js/browser dependencies so this was never
a problem but as per visjs/vis-timeline#328
we'll need this fix from now on.
Thomaash added a commit to visjs/vis-dev-utils that referenced this pull request Feb 19, 2020
We've never had combined node.js/browser dependencies so this was never
a problem but as per visjs/vis-timeline#328 we'll need this fix from now
on.
yotamberk pushed a commit to visjs/vis-dev-utils that referenced this pull request Feb 19, 2020
We've never had combined node.js/browser dependencies so this was never
a problem but as per visjs/vis-timeline#328 we'll need this fix from now
on.
@yotamberk yotamberk merged commit 3a8a42c into master Feb 19, 2020
@yotamberk yotamberk deleted the purge-vis-uuid branch February 19, 2020 22:26
@vis-bot
Copy link
Collaborator

vis-bot commented Feb 20, 2020

🎉 This PR is included in version 7.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants