Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: showStipes not working (#266) #276

Merged
merged 1 commit into from
Feb 1, 2020
Merged

fix: showStipes not working (#266) #276

merged 1 commit into from
Feb 1, 2020

Conversation

yotamberk
Copy link
Member

closes #266

@yotamberk yotamberk requested a review from a team February 1, 2020 16:00
Copy link
Member

@Thomaash Thomaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yotamberk yotamberk merged commit ca9b018 into master Feb 1, 2020
@yotamberk yotamberk deleted the fix-266 branch February 1, 2020 17:12
@vis-bot
Copy link
Collaborator

vis-bot commented Feb 1, 2020

🎉 This PR is included in version 7.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Async0x42
Copy link
Contributor

Unfortunately this fix breaks clustering when showStipes is false. Using the example page, if you disable showStipes, it throws an exception because the dot/line don't exist.

https://codepen.io/Async0x42/pen/RwPQYvY?editable=true

ClusterItem.js:542 Uncaught TypeError: Cannot read property 'offsetHeight' of undefined
    at e.value (ClusterItem.js:542)
    at e.o (ClusterItem.js:109)
    at Group.js:1126
    at Object.forEach (vis-util.js:38)
    at t.value (Group.js:1125)
    at p (Group.js:378)
    at t.value (Group.js:422)
    at Array.r (Group.js:533)
    at ItemSet.js:837
    at Object.forEach (vis-util.js:38)

@Thomaash
Copy link
Member

Hi @Async0x42,

if a PR broke something it's generally much better idea to open a new issue and link the offending PR from there. Comments on closed PRs are very prone to getting lost and forgotten rather than addressed.

@Async0x42
Copy link
Contributor

Hi @Async0x42,

if a PR broke something it's generally much better idea to open a new issue and link the offending PR from there. Comments on closed PRs are very prone to getting lost and forgotten rather than addressed.

Good to know, I'll post a new issue, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cluster.showStipes doesn't work
4 participants