-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export header and Babel preset #5
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two things are almost identical across our projects already and it makes a lot of sense to have them shared from a single source. Babel preset (TypeScript and CSS are optional): ```json { "exclude": ["**/node_modules/**"], "presets": [["vis-dev-utils/babel-preset", { "css": true, "ts": true }]] } ``` Header (reads package.json): ```javascript import { generateHeader } from "vis-dev-utils"; const banner = generateHeader(); ``` custom values can be supplied if necessary (tsdoc included): ```javascript const banner = generateHeader({ name: 'vis-timeline and vis-graph2d' }); ```
mojoaxel
approved these changes
Dec 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thomaash
added a commit
to visjs/vis-uuid
that referenced
this pull request
Dec 30, 2019
Thomaash
added a commit
to visjs/vis-util
that referenced
this pull request
Dec 30, 2019
Thomaash
added a commit
to visjs/vis-graph3d
that referenced
this pull request
Dec 30, 2019
See visjs/vis-dev-utils#5. As in other projects has already been done: - There should be no more prototype polution. - Uglify was replaced by Terser (Uglify was removing the header). - The build in banner was used instead of the plugin (the plugin was messing up source maps which now work). - Some unused dependencies were removed.
Thomaash
added a commit
to visjs/vis-data
that referenced
this pull request
Dec 30, 2019
See visjs/vis-dev-utils#5. The build in banner was used instead of the plugin (the plugin was messing up source maps which now work).
Thomaash
added a commit
to visjs/vis-data
that referenced
this pull request
Dec 30, 2019
See visjs/vis-dev-utils#5. The build in banner was used instead of the plugin (the plugin was messing up source maps which now work).
Thomaash
added a commit
to visjs/vis-network
that referenced
this pull request
Dec 30, 2019
Thomaash
added a commit
to visjs/vis-network
that referenced
this pull request
Dec 30, 2019
Thomaash
added a commit
to visjs/vis-timeline
that referenced
this pull request
Dec 30, 2019
See visjs/vis-dev-utils#5. This also removes prototype pollution associated with the previously used `useBuiltIns: true`.
yotamberk
pushed a commit
to visjs/vis-util
that referenced
this pull request
Dec 30, 2019
yotamberk
pushed a commit
to visjs/vis-timeline
that referenced
this pull request
Dec 30, 2019
See visjs/vis-dev-utils#5. This also removes prototype pollution associated with the previously used `useBuiltIns: true`.
yotamberk
pushed a commit
to visjs/vis-network
that referenced
this pull request
Dec 30, 2019
yotamberk
pushed a commit
to visjs/vis-data
that referenced
this pull request
Dec 30, 2019
See visjs/vis-dev-utils#5. The build in banner was used instead of the plugin (the plugin was messing up source maps which now work).
Thomaash
added a commit
to visjs/vis-graph3d
that referenced
this pull request
Jan 2, 2020
See visjs/vis-dev-utils#5. As in other projects has already been done: - There should be no more prototype polution. - Uglify was replaced by Terser (Uglify was removing the header). - The build in banner was used instead of the plugin (the plugin was messing up source maps which now work). - Some unused dependencies were removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two things are almost identical across our projects already and it makes a lot of sense to have them shared from a single source.
Babel preset (TypeScript and CSS are optional):
Header for bundled files (reads package.json):
custom values can be supplied if necessary (tsdoc included):