Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: support "strict" typescript settings in luma.gl #2241

Closed
ccreed1988 opened this issue Sep 3, 2024 · 1 comment
Closed
Labels
Milestone

Comments

@ccreed1988
Copy link

Some of the typings in resource.ts and shader-inputs.ts are incorrect.

I noticed that the types in resource.ts have already been corrected in the master branch but it has not yet been released on a release branch. So I wanted to make this PR to fix what I saw in the shader-inputs.ts file.

I was unable to build my Angular project without this change.

I come across the issues in luma when trying to use the deck.gl library. I created a discussion about it on the deck.gl github page: visgl/deck.gl#9109

@ibgreen ibgreen changed the title Some of the types are incorrect in some of the files Feature Request: support "strict" typescript settings in luma.gl Sep 16, 2024
@ibgreen
Copy link
Collaborator

ibgreen commented Sep 16, 2024

@ccreed1988 My understanding this was due to strict setting in the app. We have been working towards enabling strict mode in luma.gl but we are not there quite yet. I will rename this bug accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants