XCM configuration on Kreivo. #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkforest0202
commented
Jun 20, 2023
darkforest0202
commented
Jun 20, 2023
| type XcmTeleportFilter = Everything; | ||
| type XcmReserveTransferFilter = Nothing; | ||
| type XcmTeleportFilter = Nothing; | ||
| type XcmReserveTransferFilter = Everything; |
There was a problem hiding this comment.
For the future , make a test to assure that asset registry is filtering non desired assets.
darkforest0202
commented
Jun 20, 2023
olanod
reviewed
Jun 21, 2023
| type XcmTeleportFilter = Everything; | ||
| type XcmReserveTransferFilter = Nothing; | ||
| type XcmTeleportFilter = Nothing; | ||
| type XcmReserveTransferFilter = Everything; |
There was a problem hiding this comment.
The asset registry is already taking care of the filter, however we might try implementing some more specific filter. At the moment all parachains are just leaving Everything and using an asset registry to allow/disallow assets from other parachains
darkforest0202
commented
Jun 21, 2023
| type XcmTeleportFilter = Everything; | ||
| type XcmReserveTransferFilter = Nothing; | ||
| type XcmTeleportFilter = Nothing; | ||
| type XcmReserveTransferFilter = Everything; |
There was a problem hiding this comment.
The asset registry is already taking care of the filter, however we might try implementing some more specific filter. At the moment all parachains are just leaving Everything and using an asset registry to allow/disallow assets from other parachains
olanod
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following:
Still pending:
DenyThenTry<DenyNativeTokenReserveTransferToStatemine...)Related #242