-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHEL-65784: CI: Enable code style checking with clang-format [CI-NO-BUILD] #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostyanf14
changed the title
RHEL-65784: CI: Enable code style chacking with clang-format
RHEL-65784: CI: Enable code style chacking with clang-format [CI-NO-BUILD]
Nov 14, 2024
kostyanf14
force-pushed
the
clang-format-ci
branch
4 times, most recently
from
November 14, 2024 14:49
320c189
to
e0b1189
Compare
kostyanf14
force-pushed
the
clang-format-ci
branch
from
November 14, 2024 15:02
58543ff
to
76be4b3
Compare
Results when everything is ok https://github.com/virtio-win/kvm-guest-drivers-windows/actions/runs/11839831500/job/32992230697 |
kostyanf14
force-pushed
the
clang-format-ci
branch
2 times, most recently
from
November 14, 2024 15:23
77e5187
to
80776e1
Compare
YanVugenfirer
approved these changes
Nov 17, 2024
kostyanf14
changed the title
RHEL-65784: CI: Enable code style chacking with clang-format [CI-NO-BUILD]
RHEL-65784: CI: Enable code style chacking with clang-format [SKIP-HCK-CI]
Nov 17, 2024
rerun tests |
kostyanf14
changed the title
RHEL-65784: CI: Enable code style chacking with clang-format [SKIP-HCK-CI]
RHEL-65784: CI: Enable code style chacking with clang-format [CI-NO-BUILD]
Nov 18, 2024
kostyanf14
force-pushed
the
clang-format-ci
branch
2 times, most recently
from
November 18, 2024 11:03
8701a14
to
143abfe
Compare
Add empty config for clang-format. Jira: https://issues.redhat.com/browse/RHEL-65784 Signed-off-by: Konstantin Kostiuk <[email protected]>
Jira: https://issues.redhat.com/browse/RHEL-65784 Signed-off-by: Konstantin Kostiuk <[email protected]>
clang-format always check one \n at the end of file. Jira: https://issues.redhat.com/browse/RHEL-65784 Signed-off-by: Konstantin Kostiuk <[email protected]>
kostyanf14
force-pushed
the
clang-format-ci
branch
from
November 18, 2024 11:38
143abfe
to
cc685ec
Compare
Merging @kostyanf14 please update Wiki and contributing.md |
YanVugenfirer
changed the title
RHEL-65784: CI: Enable code style chacking with clang-format [CI-NO-BUILD]
RHEL-65784: CI: Enable code style checking with clang-format [CI-NO-BUILD]
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add empty config for clang-format.
Jira: https://issues.redhat.com/browse/RHEL-65784