Fix avatar attachment positions. #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides a simple rolling average hysteresis.
Allows the nametag to move up/down along with animations. Related to #142.
To consolidate metaverse API methods.
To consolidate entities and components.
This reverts commit 1beb5e8. This commit introduced a circular dependency that prevented the app from starting. I'm reverting it because I could not fix it via conventional changes
In favour of runtime type checking with `instanceof`.
Allows the camera to move up/down along with animations.
Method was retrieving `avatarController` and not using it.
|
We should put the setting in the control settings as it's more a UX thing than a graphical thing. |
|
Sounds good. Where abouts in the control settings menu do you think it should go? |
|
Let's add a tab for "Camera" with an eye icon. |
Added with commit 20dd0c7. |
Signed-off-by: Giga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the attachment of the camera and nametag to the player's avatar.
Previous:
Updated:
Video example of the new camera attachment.
A "Camera Bobbing" toggle has been added to the graphics settings menu. This toggles the bouncing/bobbing effect visible in first-person view that results from the new camera attachment method. (This setting is enabled by default).
This PR also adds a rolling average hysteresis utility class. This utility acts as a low-pass filter, smoothing values that change frequently.
Closes #180.
Closes #142.