Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe something wrong in KalmanFilter::gating_distance #18

Open
lazylazypig opened this issue Jan 19, 2024 · 2 comments
Open

Maybe something wrong in KalmanFilter::gating_distance #18

lazylazypig opened this issue Jan 19, 2024 · 2 comments
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@lazylazypig
Copy link

lazylazypig commented Jan 19, 2024

hi; in KalmanFilter.cpp, about line 120:

    if (only_position)
    {
        projected_mean.tail<4>().setZero();
        projected_covariance.bottomRightCorner<2, 2>().setZero();
    }

projected_mean is a 4-dims vector of type KFMeasSpaceVec , so projected_mean.tail<4>().setZero() will make projected_mean a zero vector; i think it's not right, and maybe the right implementation is:

    if (only_position)
    {
        projected_mean.tail<2>().setZero();
        projected_covariance.bottomRightCorner<2, 2>().setZero();
    }
@viplix3
Copy link
Owner

viplix3 commented Jan 23, 2024

Hi @lazylazypig, I will look into it this weekend!

@viplix3 viplix3 self-assigned this Jan 23, 2024
@viplix3 viplix3 added the question Further information is requested label Jan 23, 2024
@viplix3
Copy link
Owner

viplix3 commented Feb 27, 2024

@lazylazypig you are right, I will update the code today

@viplix3 viplix3 added the bug Something isn't working label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants