Add AssumeValidArg enum and correct verify_script #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the
AssumeValidArg
enum to make the disabled and hardcoded options explicit, as discussed in #126.Also I have changed
verify_script
to check whether there's an assume-valid hash, and if so also check if the block is in the best chain (now, if it is forked we won't assume the scripts). We no longer use theassume_valid
field height, as we directly fetch the disk header (in order to verify the state of the block).Updated the two examples. In florestad/src/main.rs I add a temporary conversion to
AssumeValidArg
, in next changes we could modify slightly the Command enum such that the assume-valid argument has this type.