Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devDependencies included in releases #92

Closed
iPaulis opened this issue Aug 13, 2016 · 1 comment
Closed

devDependencies included in releases #92

iPaulis opened this issue Aug 13, 2016 · 1 comment

Comments

@iPaulis
Copy link

iPaulis commented Aug 13, 2016

Windows defender found this trojan in the new build 1.1.2: https://www.microsoft.com/security/portal/threat/encyclopedia/entry.aspx?name=Trojan%3aWin32%2fVarpes.M!cl&threatid=2147708972&enterprise=0

The infected file was: \UserFolder\PokeNurse-win32-x64\resources\app\node_modules\rcedit\bin\rcedit.exe

@vinnymac
Copy link
Owner

vinnymac commented Aug 13, 2016

RCEdit.exe is a required file for windows builds. It allows modifications of executables when electron-packager builds the app. It may be possible for us to package the app without electron-packager, but that is currently the easiest way to do it, as NPM v3 flattens package dependencies. We should try excluding them if we can. Perhaps we should just use a separate package.json for development to prevent them from going into releases.

electron/packager#53

EDIT: New build system on develop fixes this issue

@vinnymac vinnymac changed the title Windows defender finds trojan in new build devDependencies included in releases Aug 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants