Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phpstub for amqp extension (php-amqp) #11172

Open
wants to merge 1 commit into
base: 5.x
Choose a base branch
from

Conversation

mkilmanas
Copy link

@mkilmanas mkilmanas commented Nov 27, 2024

Disclaimer: first time contributor here

This adds phpstub file for AMQP extension by copying contents of their originally provided stubs and concatenating into a single file.

What I am uncertain of and would like your feedback on:

  • Should stubs in psalm contain original docblocks with explanations? Or only those with annotations that help with types, deprecations, etc?
  • I have added a link to their LICENCE file (copying the whole file over seems a bit of an overkill). Is that sufficient?
  • I have found two places to register/allow the new extension - have I missed any others? It did not seem like any tests would be specifically checking for each extension, so no new tests added either.

Looking forward to your comments (and hopefully a merge at the end)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant