Remove usage of E_STRICT #11166
Open
Remove usage of E_STRICT #11166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This constant is deprecated in PHP 8.4. All E_STRICT warnings were converted to E_NOTICE in PHP 8.0. Psalm 5 still supports PHP 7.4, so _technically_ this constant could still be useful for people running it on that version, but I suspect most development and testing happens against 8.0+. It doesn't seem worth more complicated version detection in this code to me.
GromNaN
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This constant is deprecated in PHP 8.4. All
E_STRICTwarnings were converted toE_NOTICEin PHP 8.0. See the RFC for full details.Psalm 5 still supports PHP 7.4, so technically this constant could still be useful for people running it on that version, but I suspect most development and testing happens against 8.0+, and the few cases that apply to 7.4 are unlikely to matter to the Psalm code base. It doesn't seem worth more sophisticated PHP version detection in this code to me.