Psalm 5.7 started complaining about mb_strlen checks on array elements

[kamil-tekiela]

It manifests as multiple different issues. Here's one example:
https://psalm.dev/r/897a70d45b

Asserting string length doesn't mean checking if the string is non-empty.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/897a70d45b

<?php
$GLOBALS['sql_query'] = rand(0,1) ? 'asd' : null;
if(!empty($GLOBALS['sql_query']) && mb_strlen($GLOBALS['sql_query']) > 2)
{
    echo 'true';
}

Psalm output (using commit d934875):

ERROR: RedundantCondition - 3:4 - $GLOBALS['sql_query'] is non-empty has already been asserted

[weirdan]

It doesn't seem to happen on a plain variable though: https://psalm.dev/r/6178eba089

Asserting string length doesn't mean checking if the string is non-empty.

It's the other way around. Asserting non-emptyness doesn't mean the string can't be less than three chars (as in your example).

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/6178eba089

<?php
$query = rand(0,1) ? 'asd' : null;

if(!empty($query) && mb_strlen($query) > 2)
{
    echo 'true';
}

Psalm output (using commit d934875):

No issues!

[weirdan]

cc: @LeoVie

[weirdan]

It also doesn't happen with nested ifs: https://psalm.dev/r/6ad10cdab0

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/6ad10cdab0

<?php
$GLOBALS['sql_query'] = rand(0,1) ? 'asd' : null;
if (!empty($GLOBALS['sql_query'])) {
    if (mb_strlen($GLOBALS['sql_query']) > 2) {
       echo 'true';
    }
}

Psalm output (using commit d934875):

No issues!